OriginalEXE saidIf the Page Builder uses shortcodes then it shouldn’t be allowed to be a part of the theme.
2 TF staff! Did I miss something or the page builders are still allowed to use within the themes? Today is 10th of September and I’m just curious if the newly added themes use the page builders as plugins? Your response is much appreciated. Thanks.
You are talking about phase 2, which is due this November (separating functionality into plugins).Also, page builders will be allowed in Themes even in that phase, more info here: http://support.envato.com/index.php?/Knowledgebase/Article/View/472
I don’t think that’s true. The page builder would still be allowed if it has shortcodes. Shortcodes would be plugins. So if these shortcode plugins aren’t activated then they just won’t be usable within the page builder. TGM would just require those shortcode plugins.
Speaking of TGM, that code should really be updated. A lot of open issues in the repo
Congrats! I hope to be in your shoes too sometime in the future!
Google, iOS7 and Windows 8 (among others) are at fault for the trend! I myself am trying to add some minor facelifts to my old hidden themes. Not trying to make them really flat, but removing outdated designs like super less use of gradient shadows so that it would somewhat follow the current trend.
Unfortunately that plugin has issues. Although I’d advise to always keep WP_DEBUG on during development and testing, the theme should not print any warning or error anywhere.
For TGM, this issue got my theme soft rejected: https://github.com/thomasgriffin/TGM-Plugin-Activation/issues/135
Check also the pull requests for other fixes.
Sounds awesome. Applied!
That was it! The theme is now live! Thanks
Just set up a Github repo for a plugin that can help other theme devs and whatnot.
Selector Query is a jQuery plugin that adds selector classes to elements depending on its width. Think of media queries but for element widths instead of browser widths.
Hey guys, it’s my first time placing the Envato WordPress Toolkit Library in one of my themes and it’s producing a bunch of errors. I managed to fix them and placed also a pull request in Github to include them. Except for one..
Here’s the error: http://d.pr/i/Si9z
Any advice? Checking the code for the Theme_Upgrader class it looks like the error can be solved by removing the $package variable in the arguments of update() and getting the package name via:
$current = get_site_transient( 'update_themes' ); $r = $current->response[ $theme ]; $package = $r['package'];
Has anyone tried this?
Also, I really want to use this library for my buyer’s convenience.. but why is it full of errors? Isn’t the Toolkit recommended and supported anymore??